Re: [PATCH 0/4] media: i2c: vd55g1: Miscellaneous fixes

From: Sakari Ailus
Date: Tue Jun 10 2025 - 05:39:24 EST


Hi Benjamin,

On Tue, Jun 10, 2025 at 11:31:05AM +0200, Benjamin Mugnier wrote:
> Hi Sakari,
>
> Thank you for your review.
>
> On 6/10/25 11:00, Sakari Ailus wrote:
> > Hi Benjamin,
> >
> > Thanks for the set.
> >
> > On Mon, Jun 09, 2025 at 03:46:20PM +0200, Benjamin Mugnier wrote:
> >> This series provides small fixes and style improvements to the vd55g1
> >> driver.
> >> Nothing fancy really, just to keep everything up to date.
> >
> > On all (or at least more than one) patches:
> >
> > - please add a proper commit message beyond the subject line and
> >
> > - properly wrap the commit paragraphs (up to 75 characters per line, e.g.
> > the above paragraph would fit on two lines).
> >
>
> Yes, commit descriptions have been added in v2. Media-ci rightfully
> yelled at me for that ;)
>
> I don't see any commit paragraphs being above 75 characters, my vim
> seems to be properly configured.

It's not over 75 characters per line but some lines are shorter than they
could be.

> Do you mean the commit header too perhaps ? For example "media: i2c:
> vd55g1: Miscellaneous fixes".

--
Regards,

Sakari Ailus