Re: [PATCH net] netconsole: fix appending sysdata when sysdata_fields == SYSDATA_RELEASE

[Breno Leitao]

On Mon, Jun 09, 2025 at 11:24:20AM -0700, Gustavo Luiz Duarte wrote:
> Before appending sysdata, prepare_extradata() checks if any feature is
> enabled in sysdata_fields (and exits early if none is enabled).
> 
> When SYSDATA_RELEASE was introduced, we missed adding it to the list of
> features being checked against sysdata_fields in prepare_extradata().
> The result was that, if only SYSDATA_RELEASE is enabled in
> sysdata_fields, we incorreclty exit early and fail to append the
> release.
> 
> Instead of checking specific bits in sysdata_fields, check if
> sysdata_fields has ALL bit zeroed and exit early if true. This fixes
> case when only SYSDATA_RELEASE enabled and makes the code more general /
> less error prone in future feature implementation.
> 
> Signed-off-by: Gustavo Luiz Duarte <gustavold@xxxxxxxxx>

Fixes: dd30ae533242 ("netconsole: append release to sysdata")

Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx>

Thanks for the fix,
--breno