Re: [PATCH v4 09/14] selftests: harness: Move teardown conditional into test metadata
From: Nicolin Chen
Date: Tue Jun 10 2025 - 02:49:47 EST
Hi Thomas,
CC += Jason
On Mon, May 05, 2025 at 05:15:27PM +0200, Thomas Weißschuh wrote:
> To get rid of setjmp()/longjmp(), the teardown logic needs to be usable
> from __bail(). To access the atomic teardown conditional from there,
> move it into the test metadata.
> This also allows the removal of "setup_completed".
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
Certain hugepage tests in iommufd selftest (CONFIG_IOMMUFD_TEST)
start to fail since v6.16-rc1, though the test functions weren't
changed during last cycle:
------------------------------------------------------------------
# RUN iommufd_dirty_tracking.domain_dirty128M_huge.enforce_dirty ...
# enforce_dirty: Test terminated unexpectedly by signal 11
# FAIL iommufd_dirty_tracking.domain_dirty128M_huge.enforce_dirty
not ok 193 iommufd_dirty_tracking.domain_dirty128M_huge.enforce_dirty
# RUN iommufd_dirty_tracking.domain_dirty128M_huge.set_dirty_tracking ...
# set_dirty_tracking: Test terminated unexpectedly by signal 11
# FAIL iommufd_dirty_tracking.domain_dirty128M_huge.set_dirty_tracking
not ok 194 iommufd_dirty_tracking.domain_dirty128M_huge.set_dirty_tracking
# RUN iommufd_dirty_tracking.domain_dirty128M_huge.device_dirty_capability ...
# device_dirty_capability: Test terminated unexpectedly by signal 11
# FAIL iommufd_dirty_tracking.domain_dirty128M_huge.device_dirty_capability
not ok 195 iommufd_dirty_tracking.domain_dirty128M_huge.device_dirty_capability
# RUN iommufd_dirty_tracking.domain_dirty128M_huge.get_dirty_bitmap ...
# get_dirty_bitmap: Test terminated unexpectedly by signal 11
# FAIL iommufd_dirty_tracking.domain_dirty128M_huge.get_dirty_bitmap
not ok 196 iommufd_dirty_tracking.domain_dirty128M_huge.get_dirty_bitmap
# RUN iommufd_dirty_tracking.domain_dirty128M_huge.get_dirty_bitmap_no_clear ...
# get_dirty_bitmap_no_clear: Test terminated unexpectedly by signal 11
# FAIL iommufd_dirty_tracking.domain_dirty128M_huge.get_dirty_bitmap_no_clear
not ok 197 iommufd_dirty_tracking.domain_dirty128M_huge.get_dirty_bitmap_no_clear
------------------------------------------------------------------
Git bisect points to this patch, and reverting it and its following
patches fixes these.
I haven't debugged it, hoping you might have a quick thought. Lemme
know if you need some details to figure out what's going on.
Thanks
Nicolin