Re: [PATCH v3 2/2] PCI/portdrv: Add support for PCIe wake interrupt

From: Krishna Chaitanya Chundru
Date: Tue Jun 10 2025 - 00:32:22 EST




On 6/9/2025 9:59 PM, Bjorn Helgaas wrote:
On Mon, Jun 09, 2025 at 11:27:49AM +0530, Krishna Chaitanya Chundru wrote:
On 6/6/2025 1:56 AM, Bjorn Helgaas wrote:
On Thu, Jun 05, 2025 at 10:54:45AM +0530, Krishna Chaitanya Chundru wrote:
PCIe wake interrupt is needed for bringing back PCIe device state
from D3cold to D0.

+ wake = devm_fwnode_gpiod_get(&pdev->dev, of_fwnode_handle(dn),
+ "wake", GPIOD_IN, NULL);

I guess this finds "wake-gpio" or "wake-gpios", as used in
Documentation/devicetree/bindings/pci/qcom,pcie.yaml,
qcom,pcie-sa8775p.yaml, etc? Are these names specified in any generic
place, e.g.,
https://github.com/devicetree-org/dt-schema/tree/main/dtschema/schemas/pci?

I created a patch to add them in common schemas:
https://lore.kernel.org/all/20250515090517.3506772-1-krishna.chundru@xxxxxxxxxxxxxxxx/

Thanks. I think it will help other DT writers if we can include a
link to the relevant dtschema commit in this commit log.
Hi Bjorn,

I have added this link to the cover letter, I will add the link to
this commit in my next patch as this make sense to be added here.

- Krishna Chaitanya.