Re: [PATCH v2 3/4] Workqueue: add WQ_PERCPU
From: kernel test robot
Date: Mon Jun 09 2025 - 22:09:01 EST
Hi Marco,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mkp-scsi/for-next]
[cannot apply to brauner-vfs/vfs.all wireless-next/main wireless/main linus/master v6.16-rc1 next-20250606]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Marco-Crivellari/Workqueue-add-system_percpu_wq/20250609-183742
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link: https://lore.kernel.org/r/20250609103535.780069-4-marco.crivellari%40suse.com
patch subject: [PATCH v2 3/4] Workqueue: add WQ_PERCPU
config: s390-randconfig-002-20250610 (https://download.01.org/0day-ci/archive/20250610/202506100903.Ow7T6q5Q-lkp@xxxxxxxxx/config)
compiler: s390-linux-gcc (GCC) 14.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250610/202506100903.Ow7T6q5Q-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506100903.Ow7T6q5Q-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/nvme/host/tcp.c: In function 'nvme_tcp_init_module':
>> drivers/nvme/host/tcp.c:3026:26: warning: statement with no effect [-Wunused-value]
3026 | wq_flags != WQ_PERCPU;
| ~~~~~~~~~^~~~~~~~~~~~
vim +3026 drivers/nvme/host/tcp.c
3008
3009 static int __init nvme_tcp_init_module(void)
3010 {
3011 unsigned int wq_flags = WQ_MEM_RECLAIM | WQ_HIGHPRI | WQ_SYSFS;
3012 int cpu;
3013
3014 BUILD_BUG_ON(sizeof(struct nvme_tcp_hdr) != 8);
3015 BUILD_BUG_ON(sizeof(struct nvme_tcp_cmd_pdu) != 72);
3016 BUILD_BUG_ON(sizeof(struct nvme_tcp_data_pdu) != 24);
3017 BUILD_BUG_ON(sizeof(struct nvme_tcp_rsp_pdu) != 24);
3018 BUILD_BUG_ON(sizeof(struct nvme_tcp_r2t_pdu) != 24);
3019 BUILD_BUG_ON(sizeof(struct nvme_tcp_icreq_pdu) != 128);
3020 BUILD_BUG_ON(sizeof(struct nvme_tcp_icresp_pdu) != 128);
3021 BUILD_BUG_ON(sizeof(struct nvme_tcp_term_pdu) != 24);
3022
3023 if (wq_unbound)
3024 wq_flags |= WQ_UNBOUND;
3025 else
> 3026 wq_flags != WQ_PERCPU;
3027
3028 nvme_tcp_wq = alloc_workqueue("nvme_tcp_wq", wq_flags, 0);
3029 if (!nvme_tcp_wq)
3030 return -ENOMEM;
3031
3032 for_each_possible_cpu(cpu)
3033 atomic_set(&nvme_tcp_cpu_queues[cpu], 0);
3034
3035 nvmf_register_transport(&nvme_tcp_transport);
3036 return 0;
3037 }
3038
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki