Re: [PATCH] wifi: rtlwifi: Constify struct rtl_hal_ops and rtl_hal_cfg

[Ping-Ke Shih]

Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:

> 'struct rtl_hal_ops' and 'struct rtl_hal_cfg' are not modified in these
> drivers.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers.
> 
> Constification of rtl_hal_cfg is only needed in rtl8192cu/sw.c
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>   10167	   5512	    128	  15807	   3dbf	drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>   10743	   4936	    128	  15807	   3dbf	drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

4c95423b6f01 wifi: rtlwifi: Constify struct rtl_hal_ops and rtl_hal_cfg

---
https://github.com/pkshih/rtw.git