Re: [PATCH v2 1/3] mtd: spi-nor: macronix: Drop the redundant flash info fields

[Guenter Roeck]

On 6/8/25 18:13, Guenter Roeck wrote:
> On 6/8/25 05:53, Pratyush Yadav wrote:
> > On Sat, Jun 07 2025, Guenter Roeck wrote:
> >
> > > Hi,
> > >
> > > On Mon, Apr 07, 2025 at 03:53:58PM +0800, Cheng Ming Lin wrote:
> > > > From: Cheng Ming Lin <chengminglin@xxxxxxxxxxx>
> > > >
> > > > Many flash devices share the same ID but have different part numbers.
> > > > To avoid confusion, the part number field is removed.
> > > >
> > > > Additionally, since SFDP already provides size information and
> > > > functionality covered by no_sfdp_flags, these fields are also removed.
> > > >
> > > > Furthermore, when 4-byte address instruction table is available,
> > > > the SPI_NOR_4B_OPCODES flag is no longer needed and is removed.
> > > >
> > > > Signed-off-by: Cheng Ming Lin <chengminglin@xxxxxxxxxxx>
> > > > Acked-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
> > >
> > > With this patch in place, some of my qemu tests no longer recognize the
> > > flash chips (MX25L25635E/F). Do you have a suggestion on how to handle
> > > this other than avoiding Macronix flash chips when working with qemu ?
> >
> > Could you share some logs? Does the flash fail to detect, or does the
> > SFDP-based probing fail? Since this is qemu, it would be even better if
> > you can share a setup/reproduction guide. I have been meaning to set up
> > qemu for SPI NOR testing for some time now, but never got around to
> > figuring it out.
>
> I suspect that the SFDP data for the affected flashes is incorrect in qemu.
> Since this is very likely a qemu problem, I'll just configure different flash
> chips when running affected tests.

I was able to confirm the above. This is from the kernel log:

[    4.500000] spi-nor spi0.0: BFPT parsing failed. Please consider using SPI_NOR_SKIP_SFDP when declaring the flash
[    4.500000] spi-nor spi0.0: probe with driver spi-nor failed with error -22

Guenter