Re: [PATCH v2] net: qrtr: mhi: synchronize qrtr and mhi preparation

From: Jakub Kicinski
Date: Mon Jun 09 2025 - 19:00:55 EST


On Wed, 04 Jun 2025 14:05:42 -0700 Chris Lew wrote:
> + rc = qrtr_mhi_queue_rx(qdev);
> + if (rc) {
> + qrtr_endpoint_unregister(&qdev->ep);
> + mhi_unprepare_from_transfer(mhi_dev);

is ignoring the rc here intentional? may be worth a comment

> + }
> +
> dev_dbg(qdev->dev, "Qualcomm MHI QRTR driver probed\n");
>
> return 0;

Note that we return 0 here, not rc
--
pw-bot: cr