Re: [PATCH v2 4/5] arm: dts: omap: Add support for BeagleBone Green Eco board

[Andreas Kemnade]

Am Mon, 9 Jun 2025 22:45:02 +0200
schrieb Kory Maincent <kory.maincent@xxxxxxxxxxx>:

> Le Mon, 9 Jun 2025 18:04:01 +0100,
> Conor Dooley <conor@xxxxxxxxxx> a écrit :
> 
> > On Mon, Jun 09, 2025 at 05:43:54PM +0200, Kory Maincent wrote:  
> > > SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
> > > (BBG). It has minor differences from the BBG, such as a different PMIC,
> > > a different Ethernet PHY, and a larger eMMC.
> > > 
> > > Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> > > ---
> > > 
> > > Changes in v2:
> > > - Used generic pmic node name.
> > > - Add regulator prefix to fixed regulator node name.
> > > - Add the compatible to omap.yaml binding
> > > ---
> > >  Documentation/devicetree/bindings/arm/ti/omap.yaml |   1 +
> > >  arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
> > >  arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 170
> > > +++++++++++++++++++++ 3 files changed, 172 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/ti/omap.yaml
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml index
> > > c43fa4f4af81..774c13157caa 100644 ---
> > > a/Documentation/devicetree/bindings/arm/ti/omap.yaml +++
> > > b/Documentation/devicetree/bindings/arm/ti/omap.yaml @@ -145,6 +145,7 @@
> > > properties:
> > >        - description: TI bone green variants based on TI AM335
> > >          items:
> > >            - enum:
> > > +              - ti,am335x-bone-green-eco
> > >                - ti,am335x-bone-green-wireless
> > >            - const: ti,am335x-bone-green
> > >            - const: ti,am335x-bone    
> > 
> > Why is this hunk here?  
> 
> Do you mean that the binding change should be in another patch?
> 
Usually binding changes are in a separate patch. Maybe you can merge it
with Patch 2. The lonely enum looks a bit strange there, so if these
things are merged, it will look more natural.

Regards,
Andreas