Re: [PATCH net-next v2] net: macb: Add shutdown operation support

[Jakub Kicinski]

On Sat, 7 Jun 2025 13:27:13 +0530 Abin Joseph wrote:
> +	rtnl_lock();
> +	netif_device_detach(netdev);
> +
> +	if (netif_running(netdev))
> +		dev_close(netdev);
> +
> +	rtnl_unlock();

nit: could you move the netif_device_detach() after
the dev_close() call? It feels a little backwards, even
tho I think it will work just fine with current code.
Also nit2: you added an empty line before the unlock
but not after lock?
-- 
pw-bot: cr