Re: [PATCH v2 2/5] binding: omap: Add lots of missing omap AM33 compatibles

From: Andreas Kemnade
Date: Mon Jun 09 2025 - 16:15:11 EST


Am Mon, 9 Jun 2025 18:03:05 +0100
schrieb Conor Dooley <conor@xxxxxxxxxx>:

> > + - description: TI bone variants based on TI AM335
>
> "bone variant" sounds like some shortand or nickname. Are the boards not
> called "beaglebone green" and "beaglebone black"? Whatever about the
> compatible, the description should use the full name I think.
>
we have an enum below it listing all those variants. So "variants"
makes sense here, but better "TI Beaglebone variants"

> > + items:
> > + - enum:
> > + - ti,am335x-bone-black
> > + - ti,am335x-bone-green
> > + - ti,am335x-pocketbeagle
> > + - const: ti,am335x-bone
> > + - const: ti,am33xx
> > +

Regards,
Andreas