Re: [External] Re: [PATCH v8 1/4] serial: 8250: fix panic due to PSLVERR

From: Andy Shevchenko
Date: Mon Jun 09 2025 - 16:09:10 EST


On Mon, Jun 09, 2025 at 03:44:19PM +0200, Greg KH wrote:
> On Mon, Jun 09, 2025 at 09:18:02PM +0800, yunhui cui wrote:
> > On Mon, Jun 9, 2025 at 6:10 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > On Mon, Jun 09, 2025 at 03:43:45PM +0800, Yunhui Cui wrote:

...

> > > - This looks like a new version of a previously submitted patch, but you
> > > did not list below the --- line any changes from the previous version.
> > > Please read the section entitled "The canonical patch format" in the
> > > kernel file, Documentation/process/submitting-patches.rst for what
> > > needs to be done here to properly describe this.
> >
> > Can this issue reported by the bot be ignored?
>
> No, why? How do we know what changed from previous versions? Otherwise
> we assume you just ignored previous review comments?
>
> This series took at least 8 tries for some reason, might as well
> document it, right? :)

+ many to what Greg said. The main problem you have is the absence of cover
letter, where it's naturally to put changelog for the series.

--
With Best Regards,
Andy Shevchenko