Re: [PATCH] rust: pin-init: examples, tests: use `ignore` instead of conditionally compiling tests

[Benno Lossin]

On Thu Jun 5, 2025 at 5:52 PM CEST, Benno Lossin wrote:
> Change `#[cfg(cond)]` to `#[cfg_attr(not(cond), ignore)]` on tests.
>
> Ignoring tests instead of disabling them still makes them appear in the
> test list, but with `ignored`. It also still compiles the code in those
> cases.
>
> Some tests still need to be ignore, because they use types that are not
> present when the condition is false. For example the condition is
> `feature = std` and then it uses `std::thread::Thread`.
>
> Suggested-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> Link: https://lore.kernel.org/all/aDC9y829vZZBzZ2p@xxxxxxxxxx
> Link: https://github.com/Rust-for-Linux/pin-init/pull/58/commits/b004dd8e64d4cbe219a4eff0d25f0a5f5bc750ca
> Signed-off-by: Benno Lossin <lossin@xxxxxxxxxx>
> ---
>
> Depends on https://lore.kernel.org/all/20250523125424.192843-3-lossin@xxxxxxxxxx
>
> ---
>  rust/pin-init/examples/pthread_mutex.rs | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied to pin-init-next -- thanks everyone!

---
Cheers,
Benno