Re: [RFC] mm: use folio_expected_ref_count() helper for reference counting

From: Steven Rostedt
Date: Mon Jun 09 2025 - 15:32:06 EST




On June 9, 2025 3:21:20 PM EDT, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>On Mon, Jun 09, 2025 at 05:08:07PM +0000, Shivank Garg wrote:
>> Replace open-coded folio reference count calculations with the
>> folio_expected_ref_count() helper to improve code maintainability
>> and reduce duplication.
>
>If it needs this much additional commentary, perhaps it's not actually
>clearer?

I don't know. I tend to over explain as I rather make it totally obvious what is happening. I wouldn't say excessive commentary is necessarily a sign that it's not clearer.

Not knowing the code, the explanation makes sense to me.

-- Steve