Re: [PATCH v1 0/3] cgroup: Add lock guard support
From: Tejun Heo
Date: Mon Jun 09 2025 - 12:35:18 EST
On Sat, Jun 07, 2025 at 12:18:38AM +0800, Jemmy Wong wrote:
> v1 changes:
> - remove guard support for BPF
> - split patch into parts
>
> v0 link:
> https://lore.kernel.org/all/20250605211053.19200-1-jemmywong512@xxxxxxxxx/
>
> Jemmy Wong (3):
> cgroup: add lock guard support for cgroup_muetx
> cgroup: add lock guard support for css_set_lock and rcu
> cgroup: add lock guard support for others
So, I'm rather ambivalent about this patchset but leaning towards not
applying them. The lock guards are fine but I'm not sure what converting the
existing code base wholesale buys us. We're already pretty good at detecting
locking problems with lockdep and all and the code being modified hasn't
seen significant locking changes in ages. There are no practical benefits to
converting the code base at this point.
Thanks.
--
tejun