Re: [PATCH v4] rust: regulator: add a bare minimum regulator abstraction

From: Daniel Almeida
Date: Mon Jun 09 2025 - 12:31:47 EST


Hi Miguel,

Sure, thank you!

By the way, are you using some lint to generate this?

> On 9 Jun 2025, at 13:23, Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Mon, Jun 9, 2025 at 5:34 PM Daniel Almeida
> <daniel.almeida@xxxxxxxxxxxxx> wrote:
>>
>> Add a bare minimum regulator abstraction to be used by Rust drivers.
>> This abstraction adds a small subset of the regulator API, which is
>> thought to be sufficient for the drivers we have now.
>
> For future versions, or at apply time, please see the attached diff
> for some documentation fixes (mostly) -- please check with
> `--ignore-space-change`, since some indentation fixes can hide other
> changes.
>
> Most should be self-explanatory, but if there is something that you
> think should not be done, please let me know of course.
>
> Thanks!
>
> Cheers,
> Miguel
> <docfixes.diff>


Also,

> -/// Enabling a regulator:
> +/// ## Enabling a regulator
> ///

Did you try to render this? I tried it before submitting, but it did not render
correctly after the first time it was used, i.e.: only the first subsection was
rendered correctly and the others remained as-is.

— Daniel