Re: [PATCH v4 2/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support

[George Moussalem]

On 6/9/25 16:16, Andrew Lunn wrote:
> > +  - |
> > +    #include <dt-bindings/reset/qcom,gcc-ipq5018.h>
> > +
> > +    mdio {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        /* add alias to set qcom,dac-preset-short-cable on boards that need it */
> > +        ge_phy: ethernet-phy@7 {
> > +            compatible = "ethernet-phy-id004d.d0c0";
> > +            reg = <7>;
> > +
> > +            resets = <&gcc GCC_GEPHY_MISC_ARES>;
>
> What do you mean by 'alias' here?

I mean node label. Since it was asked whether it's needed, I added a 
comment to say why, so that boards can reference it to set the 
qcom,dac-preset-short-cable property in the DTS as needed.

> 	Andrew

Best regards,
George