Re: [PATCH v3 2/3] i2c: amd-isp: Initialize unique adpater name

[Ilpo Järvinen]

On Mon, 9 Jun 2025, Ilpo Järvinen wrote:

> On Fri, 6 Jun 2025, Pratap Nirujogi wrote:

You also have a typo in the subject, adpater -> adapter.

> > Initialize unique name for amdisp i2c adapter, which is used
> > in the platform driver to detect the matching adapter for
> > i2c_client creation.
> > 
> > Add definition of amdisp i2c adapter name in a new header file
> > (include/linux/soc/amd/isp4_misc.h) as it is referred in different
> > driver modules.
> > 
> > Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > Signed-off-by: Pratap Nirujogi <pratap.nirujogi@xxxxxxx>
> > ---
> >  drivers/i2c/busses/i2c-designware-amdisp.c |  2 ++
> >  include/linux/soc/amd/isp4_misc.h          | 12 ++++++++++++
> 
> You forgot to add this new file into MAINTAINERS file.
> 
> >  2 files changed, 14 insertions(+)
> >  create mode 100644 include/linux/soc/amd/isp4_misc.h
> > 
> > diff --git a/drivers/i2c/busses/i2c-designware-amdisp.c b/drivers/i2c/busses/i2c-designware-amdisp.c
> > index ad6f08338124..450793d5f839 100644
> > --- a/drivers/i2c/busses/i2c-designware-amdisp.c
> > +++ b/drivers/i2c/busses/i2c-designware-amdisp.c
> > @@ -8,6 +8,7 @@
> >  #include <linux/module.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/pm_runtime.h>
> > +#include <linux/soc/amd/isp4_misc.h>
> >  
> >  #include "i2c-designware-core.h"
> >  
> > @@ -62,6 +63,7 @@ static int amd_isp_dw_i2c_plat_probe(struct platform_device *pdev)
> >  
> >  	adap = &isp_i2c_dev->adapter;
> >  	adap->owner = THIS_MODULE;
> > +	scnprintf(adap->name, sizeof(adap->name), AMDISP_I2C_ADAP_NAME);
> >  	ACPI_COMPANION_SET(&adap->dev, ACPI_COMPANION(&pdev->dev));
> >  	adap->dev.of_node = pdev->dev.of_node;
> >  	/* use dynamically allocated adapter id */
> > diff --git a/include/linux/soc/amd/isp4_misc.h b/include/linux/soc/amd/isp4_misc.h
> > new file mode 100644
> > index 000000000000..6738796986a7
> > --- /dev/null
> > +++ b/include/linux/soc/amd/isp4_misc.h
> > @@ -0,0 +1,12 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +
> > +/*
> > + * Copyright (C) 2025 Advanced Micro Devices, Inc.
> > + */
> > +
> > +#ifndef __SOC_ISP4_MISC_H
> > +#define __SOC_ISP4_MISC_H
> > +
> > +#define AMDISP_I2C_ADAP_NAME "AMDISP DesignWare I2C adapter"
> > +
> > +#endif
> > 
> 
> 

-- 
 i.