Re: [PATCH v6 12/12] pinctrl: Add pin controller driver for AAEON UP boards

[Thomas Richard]

Hi Andy,

Thanks for the review.

On 5/21/25 17:32, Andy Shevchenko wrote:
>> +static void upboard_pinctrl_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s,
>> +				     unsigned int offset)
>> +{
>> +	int ret;
>> +
>> +	ret = upboard_pinctrl_pin_get_mode(pctldev, offset);
>> +	if (ret == UPBOARD_PIN_MODE_FUNCTION)
>> +		seq_puts(s, "mode function ");
>> +	else if (ret == UPBOARD_PIN_MODE_DISABLED)
>> +		seq_puts(s, "HIGH-Z ");
> 
>> +	else
>> +		seq_printf(s, "GPIO (%s) ", str_input_output(ret == UPBOARD_PIN_MODE_GPIO_IN));
> 
> Actually this should be
> 
> 	else if (ret < 0)
> 		seq_printf(s, "N/A "); // or similar text
> 	else
> 		seq_printf(s, "GPIO (%s) ", str_input_output(ret == UPBOARD_PIN_MODE_GPIO_IN));
> 
> as the above may return a negative error code which is not listed here.
> 
>> +}
> 
> With the above being addressed,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> ...
> 
> Thanks for doing this driver, eventually we will have it working
> out-of-the-box. Do you have any plans for enabling HSI and SIM card
> slot on UP Squared 7000?

My scope is limited to the FPGA support, and I don't know the status of
HSI and SIM card slot.

But it is planned to add UP Squared 7000 support in the pinctrl driver.

Best Regards,

Thomas