Re: [PATCH] dt-bindings: phy: Convert marvell,comphy-cp110 to DT schema

[Miquel Raynal]

Hi Rob,

Thanks for the conversion.

On 07/06/2025 at 16:26:03 -05, "Rob Herring (Arm)" <robh@xxxxxxxxxx> wrote:

> Convert the Marvell CP110 combo PHY binding to DT schema format. It's a
> straight forward conversion.
>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>

[...]

> +properties:
> +  compatible:
> +    enum:
> +      - marvell,comphy-cp110
> +      - marvell,comphy-a3700
> +
> +  reg:
> +    minItems: 1
> +    items:
> +      - description: Generic COMPHY registers

Would you mind to add "(Armada 7k/8k)" here? This information was in the
description and got lost. Armada 7k/8k had (IIRC) a number of
Application Processors and Co-Processors, it might not be
straightforward to guess what "cp110" means to people not familiar with
Marvell naming otherwise?

> +      - description: Lane 1 (PCIe/GbE) registers (Armada 3700)
> +      - description: Lane 0 (USB3/GbE) registers (Armada 3700)
> +      - description: Lane 2 (SATA/USB3) registers (Armada 3700)
> +
> +  reg-names:
> +    minItems: 1

minItems should probably be 4 as it is only required (and mandatory) for
the marvell,comphy-a3700 compatible? I do not think we intended to ask
for a reg-names property when there was just one entry (see
armada-cp11x.dtsi).

> +    items:
> +      - const: comphy
> +      - const: lane1_pcie_gbe
> +      - const: lane0_usb3_gbe
> +      - const: lane2_sata_usb3
> +
> +  '#address-cells':
> +    const: 1

Should be required?

> +
> +  '#size-cells':
> +    const: 0

Should be required as well?

> +
> +  clocks:
> +    maxItems: 3
> +    description: Reference clocks for CP110; MG clock, MG Core clock, AXI clock
> +
> +  clock-names:
> +    items:
> +      - const: mg_clk
> +      - const: mg_core_clk
> +      - const: axi_clk
> +
> +  marvell,system-controller:
> +    description: Phandle to the Marvell system controller (CP110 only)
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +patternProperties:
> +  '^phy@[0-2]$':

Technically, these nodes are also mandatory, I don't remember if we can
mark them as such in the "required" section though.

> +    description: A COMPHY lane child node
> +    type: object
> +    additionalProperties: false
> +
> +    properties:
> +      reg:
> +        description: COMPHY lane number
> +
> +      '#phy-cells':
> +        const: 1
> +
> +    required:
> +      - reg
> +      - '#phy-cells'
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

Thanks,
Miquèl