Re: [PATCH v7 12/12] Documentation: mm: update the admin guide for mTHP collapse

[Baolin Wang]

On 2025/6/9 13:26, Dev Jain wrote:
> On 09/06/25 8:36 am, Baolin Wang wrote:
> > On 2025/6/9 03:50, Nico Pache wrote:
> > > On Sat, Jun 7, 2025 at 8:35 AM Dev Jain <dev.jain@xxxxxxx> wrote:
> > > > On 07/06/25 6:27 pm, Nico Pache wrote:
> > > > > On Sat, Jun 7, 2025 at 12:45 AM Dev Jain <dev.jain@xxxxxxx> wrote:
> > > > > > On 15/05/25 8:52 am, Nico Pache wrote:
> > > > > >
> > > > > > Now that we can collapse to mTHPs lets update the admin guide to
> > > > > > reflect these changes and provide proper guidence on how to 
> > > > > > utilize it.
> > > > > >
> > > > > > Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx>
> > > > > > Signed-off-by: Nico Pache <npache@xxxxxxxxxx>
> > > > > > ---
> > > > > >    Documentation/admin-guide/mm/transhuge.rst | 14 +++++++++++++-
> > > > > >    1 file changed, 13 insertions(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/Documentation/admin-guide/mm/transhuge.rst 
> > > > > > b/Documentation/admin-guide/mm/transhuge.rst
> > > > > > index dff8d5985f0f..5c63fe51b3ad 100644
> > > > > > --- a/Documentation/admin-guide/mm/transhuge.rst
> > > > > > +++ b/Documentation/admin-guide/mm/transhuge.rst
> > > > > >
> > > > > >
> > > > > > We need to modify/remove the following paragraph:
> > > > > >
> > > > > > khugepaged currently only searches for opportunities to collapse to
> > > > > > PMD-sized THP and no attempt is made to collapse to other THP
> > > > > > sizes.
> > > > > On this version this is currently still true, but once I add Baolin's
> > > > > patch it will not be true. Thanks for the reminder :)
> > > >
> > > > You referenced Baolin's patch in the other email too, can you send 
> > > > the link,
> > > > or the patch?
> > >
> > > He didn't send it to the mailing list, but rather off chain to all the
> > > recipients of this series. You should have it in your email look for
> > >
> > > Subject: "mm: khugepaged: allow khugepaged to check all anonymous mTHP
> > > orders" and "mm: khugepaged: kick khugepaged for enabling
> > > none-PMD-sized mTHPs"
> >
> > You can find them at the following link:
> > https://lore.kernel.org/all/ac9ed6d71b439611f9c94b3506a8ce975d4636e9.1748435162.git.baolin.wang@xxxxxxxxxxxxxxxxx/
>
>
> Thanks! Looks quite similar to my approach.

Sorry, I didn't see your previous patches (if I had, it would have saved 
me a lot of testing time:) ).