Re: [PATCH] powerpc: unify two CONFIG_POWERPC64_CPU entries in the same choice block

[Masahiro Yamada]

On Mon, Jun 9, 2025 at 9:59 AM Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
>
> Masahiro Yamada <masahiroy@xxxxxxxxxx> writes:
> > There are two CONFIG_POWERPC64_CPU entries in the "CPU selection"
> > choice block.
> >
> > I guess the intent is to display a different prompt depending on
> > CPU_LITTLE_ENDIAN: "Generic (POWER5 and PowerPC 970 and above)" for big
> > endian, and "Generic (POWER8 and above)" for little endian.
>
> Yeah.
>
> > I stumbled on this tricky use case, and worked around it on Kconfig with
> > commit 4d46b5b623e0 ("kconfig: fix infinite loop in sym_calc_choice()").
> > However, I doubt that supporting multiple entries with the same symbol
> > in a choice block is worth the complexity - this is the only such case
> > in the kernel tree.
> >
> > This commit merges the two entries. Once this cleanup is accepted in
> > the powerpc subsystem, I will proceed to refactor the Kconfig parser.
>
> OK. Sorry for the trouble.
>
> It could be split into two symbols to keep the separate prompts, but it's
> probably not worth the trouble.
>
> Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> (powerpc)

No rush for this patch.
Please take it to your ppc tree.
Thank you.


Best Regards
Masahiro Yamada