Re: [PATCH] cifs: Show reason why autodisabling serverino support

[Steve French]

Since this could flood logs (e.g. in some DFS cases), probably better
to do these via the usual dynamic trace points (and can document a
simple "trace-cmd -e smb3_disable_serverino" script to avoid risk of
flooding logs.    cifsFYI is an alternative but the world has moved to
the dynamic tracing (eBPF etc.)

On Sun, Jun 8, 2025 at 3:57 PM Paulo Alcantara <pc@xxxxxxxxxxxxx> wrote:
>
> Pali Rohár <pali@xxxxxxxxxx> writes:
>
> > Before calling cifs_autodisable_serverino() function, show reason why it
> > has to be called.
> >
> > This change allows to debug issues why cifs.ko decide to turn off server
> > inode number support and hence disable support for detection of hardlinks.
> >
> > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > ---
> >  fs/smb/client/connect.c   | 2 ++
> >  fs/smb/client/dfs_cache.c | 2 ++
> >  fs/smb/client/inode.c     | 3 +++
> >  fs/smb/client/readdir.c   | 3 +++
> >  4 files changed, 10 insertions(+)
>
> NACK.
>


-- 
Thanks,

Steve