Re: [PATCH] LoongArch: Fix build warnings about export.h

[Masahiro Yamada]

On Sun, Jun 8, 2025 at 11:15 PM Huacai Chen <chenhuacai@xxxxxxxxxxx> wrote:
>
> After commit a934a57a42f64a4 ("scripts/misc-check: check missing #include
> <linux/export.h> when W=1") and 7d95680d64ac8e836c ("scripts/misc-check:
> check unnecessary #include <linux/export.h> when W=1"), we get some build
> warnings with W=1:
>
> arch/loongarch/kernel/acpi.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/loongarch/kernel/alternative.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/loongarch/kernel/kfpu.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/loongarch/kernel/traps.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/loongarch/kernel/unwind_guess.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/loongarch/kernel/unwind_orc.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/loongarch/kernel/unwind_prologue.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/loongarch/lib/crc32-loongarch.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/loongarch/lib/csum.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> arch/loongarch/kernel/elf.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
> arch/loongarch/kernel/paravirt.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
> arch/loongarch/pci/pci.c: warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present
>
> So fix these build warnings for LoongArch.
>
> Signed-off-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> ---
>  arch/loongarch/kernel/acpi.c            | 1 +
>  arch/loongarch/kernel/alternative.c     | 1 +
>  arch/loongarch/kernel/elf.c             | 1 -
>  arch/loongarch/kernel/kfpu.c            | 1 +
>  arch/loongarch/kernel/paravirt.c        | 1 -
>  arch/loongarch/kernel/traps.c           | 1 +
>  arch/loongarch/kernel/unwind_guess.c    | 1 +
>  arch/loongarch/kernel/unwind_orc.c      | 3 ++-
>  arch/loongarch/kernel/unwind_prologue.c | 1 +
>  arch/loongarch/lib/crc32-loongarch.c    | 1 +
>  arch/loongarch/lib/csum.c               | 1 +
>  arch/loongarch/pci/pci.c                | 1 -
>  12 files changed, 10 insertions(+), 4 deletions(-)

Thank you for your contribution.

Reviewed-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>



-- 
Best Regards
Masahiro Yamada