Re: [PATCH] PCI/pwrctrl: Fix double cleanup on devm_add_action_or_reset() failure

[Marek Vasut]

On 6/4/25 10:38 AM, Geert Uytterhoeven wrote:
> When devm_add_action_or_reset() fails, it calls the passed cleanup
> function.  Hence the caller must not repeat that cleanup.
>
> Replace the "goto err_regulator_free" by the actual freeing, as there
> will never be a need again for a second user of this label.
>
> Fixes: 75996c92f4de309f ("PCI/pwrctrl: Add pwrctrl driver for PCI slots")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> Compile-tested only.
Reviewed-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
Tested-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx> # V4H Sparrow Hawk

Thanks !