Re: [PATCH net-next V2 07/11] net/mlx5e: SHAMPO: Headers page pool stats

From: Tariq Toukan
Date: Sun Jun 08 2025 - 06:09:42 EST




On 06/06/2025 13:43, Cosmin Ratiu wrote:
On Thu, 2025-05-22 at 15:58 -0700, Saeed Mahameed wrote:
On 22 May 15:31, Jakub Kicinski wrote:
On Fri, 23 May 2025 00:41:22 +0300 Tariq Toukan wrote:
Expose the stats of the new headers page pool.

Nope. We have a netlink API for page pool stats.


We already expose the stats of the main pool in ethtool.
So it will be an inconvenience to keep exposing half of the stats.
So either we delete both or keep both. Some of us rely on this for
debug


What is the conclusion here?
Do we keep this patch, to have all the stats in the same place?
Or do we remove it, and then half of the stats will be accessible
through both ethtool and netlink, and the other half only via netlink?

Cosmin.

IIRC, the netlink API shows only the overall/sum, right?

ethtool stats show you per-ring numbers, this is very helpful for system monitoring and perf debug.