Re: [PATCH 5/9] docs: kdoc: remove the KernelEntry::is_kernel_comment member

[Mauro Carvalho Chehab]

Em Sat, 07 Jun 2025 07:22:51 -0600
Jonathan Corbet <corbet@xxxxxxx> escreveu:

> Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> writes:
> 
> > Em Fri,  6 Jun 2025 10:34:34 -0600
> > Jonathan Corbet <corbet@xxxxxxx> escreveu:
> >  
> >> entry::is_kernel_comment never had anything to do with the entry itself; it
> >> is a bit of local state in one branch of process_name().  It can, in fact,
> >> be removed entirely; rework the code slightly so that it is no longer
> >> needed.
> >> 
> >> No change in the rendered output.
> >> 
> >> Signed-off-by: Jonathan Corbet <corbet@xxxxxxx>  
> >
> > Not sure about this one. The idea of those warnings are to detect 
> > non-kerneldoc markups that typically comes when someone "imports"
> > OOT drivers or Windows one into Linux.
> >
> > I remember I catched several such cases in the past with the help
> > of those warnings.  
> 
> I haven't removed the warning, just the use of that specific variable to
> trigger it.

After looking a the patch again, it sounds OK to me.

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>

Regards,
Mauro