Re: [PATCH v6 2/4] usb: misc: onboard_usb_dev: Add Bison Electronics Inc. Integrated Camera

[Dmitry Baryshkov]

On Sat, Jun 07, 2025 at 09:19:37PM +0200, Jens Glathe via B4 Relay wrote:
> From: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
> 
> The Camera is built into the Thinkbook 16 G7 QOY and directly attached on the
> usb_2 controller (dwc3 USB2 only). It has a separate power supply that needs
> to be controlled for PM.
> 
> Add the support for this device for the power supply.
> 
> Signed-off-by: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/usb/misc/onboard_usb_dev.c | 2 ++
>  drivers/usb/misc/onboard_usb_dev.h | 8 ++++++++
>  2 files changed, 10 insertions(+)
> 
> @@ -127,6 +134,7 @@ static const struct of_device_id onboard_dev_match[] = {
>  	{ .compatible = "usb451,8142", .data = &ti_tusb8041_data, },
>  	{ .compatible = "usb451,8440", .data = &ti_tusb8041_data, },
>  	{ .compatible = "usb451,8442", .data = &ti_tusb8041_data, },
> +	{ .compatible = "usb5986,1198", .data = &bison_intcamera_data, },

The list is sorted, so this should be the last entry.

With that fixed:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>


>  	{ .compatible = "usb4b4,6504", .data = &cypress_hx3_data, },
>  	{ .compatible = "usb4b4,6506", .data = &cypress_hx3_data, },
>  	{ .compatible = "usb4b4,6570", .data = &cypress_hx2vl_data, },
> 
> -- 
> 2.48.1
> 
> 

-- 
With best wishes
Dmitry