Re: [PATCH v4 01/11] dt-bindings: iio: adc: Add AD4170

From: Jonathan Cameron
Date: Sat Jun 07 2025 - 12:33:42 EST


On Mon, 2 Jun 2025 17:52:31 -0300
Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx> wrote:

> On 06/02, Rob Herring (Arm) wrote:
> >
> > On Mon, 02 Jun 2025 08:36:24 -0300, Marcelo Schmitt wrote:
> > > Add device tree documentation for AD4170 and similar sigma-delta ADCs.
> > > The AD4170 is a 24-bit, multichannel, sigma-delta ADC.
> > >
> > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>
> >
> ...
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad4170.yaml: properties:interrupt-names: 'enum' should not be valid under {'enum': ['const', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'minimum', 'maximum', 'multipleOf', 'pattern']}
> > hint: Scalar and array keywords cannot be mixed
> > from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
>
> Removing maxItems from under interrupt-names seems to solve the issue.

As per feedback on v3. I don't think we should be limiting the max
of interrupt-names anyway. We should allow two interrupts if they
are both wired - it's a driver choice on which one to use.

>
> Thanks
>