Re: [PATCH v4 1/2] ARM: dts: microchip: sama7g5: Adjust clock xtal phandle
From: Claudiu Beznea
Date: Sat Jun 07 2025 - 07:53:55 EST
Hi, Ryan,
On 23.05.2025 23:24, Ryan.Wanner@xxxxxxxxxxxxx wrote:
> From: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx>
>
> Adjust clock xtal phandles to match the new xtal phandle formatting.
>
> Signed-off-by: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/microchip/at91-sama7g5ek.dts | 18 ++++++++----------
> arch/arm/boot/dts/microchip/sama7g5.dtsi | 6 ++++--
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts b/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts
> index 2543599013b1..79bf58f8c02e 100644
> --- a/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts
> @@ -35,16 +35,6 @@ aliases {
> i2c2 = &i2c9;
> };
>
> - clocks {
> - slow_xtal {
> - clock-frequency = <32768>;
> - };
> -
> - main_xtal {
> - clock-frequency = <24000000>;
> - };
> - };
> -
> gpio-keys {
> compatible = "gpio-keys";
>
> @@ -512,6 +502,10 @@ spi11: spi@400 {
> };
> };
>
> +&main_xtal {
> + clock-frequency = <24000000>;
> +};
> +
Please keep it alphanumerically sorted.
> &gmac0 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -917,3 +911,7 @@ &vddout25 {
> vin-supply = <&vdd_3v3>;
> status = "okay";
> };
> +
> +&slow_xtal {
> + clock-frequency = <32768>;
> +};
Same for this one.
> diff --git a/arch/arm/boot/dts/microchip/sama7g5.dtsi b/arch/arm/boot/dts/microchip/sama7g5.dtsi
> index 17bcdcf0cf4a..411db7e375a6 100644
> --- a/arch/arm/boot/dts/microchip/sama7g5.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama7g5.dtsi
> @@ -117,13 +117,15 @@ map1 {
> };
>
> clocks {
> - slow_xtal: slow_xtal {
> + slow_xtal: clock-slowxtal {
> compatible = "fixed-clock";
> + clock-output-names = "slow_xtal";
> #clock-cells = <0>;
> };
>
> - main_xtal: main_xtal {
> + main_xtal: clock-mainxtal {
> compatible = "fixed-clock";
> + clock-output-names = "main_xtal";
> #clock-cells = <0>;
> };
While at it, can you please also address usb_clk ?
Thank you,
Claudiu