Re: [PATCH v10 07/12] iio: adc: ad7768-1: Add GPIO controller support

[Jonathan Santos]

On 06/05, Andy Shevchenko wrote:
> On Wed, Jun 04, 2025 at 04:36:43PM -0300, Jonathan Santos wrote:
> > From: Sergiu Cuciurean <sergiu.cuciurean@xxxxxxxxxx>
> > 
> > The AD7768-1 has the ability to control other local hardware (such as gain
> > stages),to power down other blocks in the signal chain, or read local
> > status signals over the SPI interface.
> > 
> > Add direct mode conditional locks in the gpio callbacks to prevent register
> 
> GPIO
> 
> > access when the device is in buffered mode.
> > 
> > This change exports the AD7768-1's four gpios and makes them accessible
> 
> GPIOs
> 
> > at an upper layer.
> 
> ...
> 
> I haven't seen in the commit message nor in the comments why GPIO regmap can't
> be used. (No need to resend, just reply here, but keep in mind in case of a new
> version of the series.)
>

We did discussed this, see [1] and [2]. It would need a few tweaks on
the gpio regmap driver, but I will keep that in mind, thanks.

[1]: https://lore.kernel.org/linux-iio/7c5e2364-038b-48a8-ad67-3cf0f2fd2be3@xxxxxxxxxxxx/
[2]: https://lore.kernel.org/linux-iio/ddb448f0-1cfc-497b-ac1f-9f3d9e9fcc3a@xxxxxxxxxxxx/

> -- 
> With Best Regards,
> Andy Shevchenko
> 
>