Re: [PATCH v2] platform/x86: Move Lenovo files into lenovo subdir
From: Mark Pearson
Date: Fri Jun 06 2025 - 15:30:53 EST
Thanks Andy
On Fri, Jun 6, 2025, at 2:58 PM, Andy Shevchenko wrote:
> On Fri, Jun 06, 2025 at 09:57:17PM +0300, Andy Shevchenko wrote:
>> On Fri, Jun 06, 2025 at 01:30:25PM -0400, Mark Pearson wrote:
>> > On Fri, Jun 6, 2025, at 11:58 AM, kernel test robot wrote:
>
> ...
>
>> > I'm unable to reproduce this issue with a W=1 build
>>
>> Do you have GCC-12?
>
> To be more precise you need to have a CONFIG_DMI=n.
>
>> > and I think it's a false positive.
>>
>> I think the problematic line is in certificate_store().
>> You need to check the value of dmi_get_system_info().
>> Or make sure the DMI is always selected (depend on DMI
>> in Kconfig, perhaps).
>>
I think this is already in place, but it's a bit of a tangled nest of Kconfig options and could depend on the architecture. I can't disable it in my current build anyway.
>> > Am I safe to ignore this report?
>>
>> Please, try to fix it.
Ack.
I'll add in a check for the dmi_get_system_info returning NULL, and add a depends on DMI.
Thanks for the pointers.
Mark