Re: [PATCH v5 3/8] soc: qcom: geni-se: Enable QUPs on SA8255p Qualcomm platforms

From: Bryan O'Donoghue
Date: Wed Jun 04 2025 - 04:24:09 EST


On 04/06/2025 08:28, Praveen Talari wrote:
should i keep condition before assign num_clks to wrapper->num_clks as
below right?

if(desc->num_clks > MAX_CLKS){
{
return dev_err_probe(dev, " to many clocks defined in descriptor:%u
(max allowed: %u)\n", desc->num_clks, MAX_CLKS);
}

Its up to you if you think this check is justified and/or necessary but, if you decide you want it then it should be an error if the specified size exceeds your defined MAX.

---
bod