Re: [PATCH v3 2/2] arm64: dts: qcom: sa8775p: Remove max link speed property for PCIe EP

[Mrinmay Sarkar]

On Fri, May 30, 2025 at 4:26 PM Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>
> On 5/30/25 12:50 PM, Konrad Dybcio wrote:
> > On 5/30/25 7:38 AM, Mrinmay Sarkar wrote:
> >> On Tue, May 27, 2025 at 4:06 PM Konrad Dybcio
> >> <konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
> >>>
> >>> On 5/25/25 3:29 PM, Dmitry Baryshkov wrote:
> >>>> On Sun, May 25, 2025 at 11:27:18AM +0530, Mrinmay Sarkar wrote:
> >>>>> From: Mrinmay Sarkar <mrinmay.sarkar@xxxxxxxxxxxxxxxx>
> >>>>>
> >>>>> The maximum link speed was previously restricted to Gen3 due to the
> >>>>> absence of Gen4 equalization support in the driver.
> >>>>>
> >>>>> Add change to remove max link speed property, Since Gen4 equalization
> >>>>> support has already been added into the driver.
> >>>>
> >>>> As Gen4 equalization is already supported by the XYZ driver remove the
> >>>> max-link-speed property.
> >>>>
> >>>> "Add change to remove" is a bit clumsy.
> >>>
> >>> I'm more worried about this node not having these gen4 eq settings
> >>> (i.e. the part talking about driver support landing is true, but it's
> >>> unused without the presets being explicitly defined in eq-presets-16gts)
> >>>
> >>> Konrad
> >>
> >> Hi Konrad,
> >>
> >> Actually stability issue was resolved by this patch series:
> >> https://lore.kernel.org/linux-pci/20240911-pci-qcom-gen4-stability-v7-3-743f5c1fd027@xxxxxxxxxx/
> >> and I don't think we need to define eq-presets-16gts for this.
> >
> > Okay, so there's multiple parts to it..
> >
> > I was referring to this series
> >
> > https://lore.kernel.org/all/20250328-preset_v6-v9-0-22cfa0490518@xxxxxxxxxxxxxxxx/
> >
> > Please check if you need this as well
>
> If not, we can get this merged as-is
>
> Konrad

Actually the series you are referring to is not required.

Thanks,
Mrinmay