Re: [PATCH v5 20/29] x86,fs/resctrl: Fill in details of Clearwater Forest events

[Reinette Chatre]

Hi Tony,

On 5/21/25 3:50 PM, Tony Luck wrote:
> +/**
> + * struct pmt_event - Telemetry event.
> + * @evtid:	Resctrl event id
> + * @evt_idx:	Counter index within each per-RMID block of counters
> + * @bin_bits:	Zero for integer valued events, else number bits in fixed-point
> + */
> +struct pmt_event {
> +	enum resctrl_event_id	evtid;
> +	int			evt_idx;
> +	int			bin_bits;
> +};

It seems redundant to have "evt" in names of member when variable will
already have "evts" during access. Resulting in code like:
evts[i].evtid and evts[i].evt_idx when just
evts[i].id and evts[i].idx would be just as descriptive.

Reinette