Re: [PATCH v5 07/29] x86,fs/resctrl: Rename some L3 specific functions

[Reinette Chatre]

Hi Tony,

On 5/21/25 3:50 PM, Tony Luck wrote:
> All monitor events used to be connected to the L3 resource so
> it was OK for function names to be generic. But this will cause
> confusion with additional events tied to other resources.
> 
> Rename functions that are only used for L3 features:

This does not rename all functions that are only used for L3 features.
Could you please add criteria used to decide which ones to rename?

> 
> arch_mon_domain_online()	-> arch_l3_mon_domain_online()
> mon_domain_free()		-> l3_mon_domain_free()

This separates the alloc and free partner functions even more.
The partner, while not completely symmetrical, is arch_domain_mbm_alloc().
How about naming arch_domain_mbm_alloc() -> l3_mon_domain_mbm_alloc()
to at least be closer?

> domain_setup_mon_state()	-> domain_setup_l3_mon_state

nit: domain_setup_l3_mon_state -> domain_setup_l3_mon_state()

This breaks symmetry with domain_destroy_mon_state(). Can domain_destroy_mon_state()
be renamed to domain_destroy_l3_mon_state()?

Reinette