Re: [PATCH v5 03/29] x86/resctrl: Remove 'rdt_mon_features' global variable
From: Reinette Chatre
Date: Tue Jun 03 2025 - 23:27:51 EST
Hi Tony,
On 5/21/25 3:50 PM, Tony Luck wrote:
> This variable was used as a bitmask of enabled monitor events. But
> that function is now provided by the filesystem mon_event_all[] array.
>
> Remove the remaining uses of this variable.
I do not see any reason why this changelog needs to be so obfuscated. Why go
through effort of referring to rdt_mon_features as "this variable" throughout
changelog when it could just be called by name? Same with "that function".
Compare with:
rdt_mon_features is used as a bitmask of enabled monitor events. A monitor
event's status is now maintained in mon_evt::enabled with all monitor
events' mon_evt structures found in the filesystem's mon_event_all[] array.
Remove the remaining uses of rdt_mon_features.
Patch looks good.
Reinette