RE: [PATCH v1 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series SoC
From: Jammy Huang
Date: Tue Jun 03 2025 - 20:48:24 EST
> On 03/06/2025 11:22, Krzysztof Kozlowski wrote:
> >> +required:
> >> + - compatible
> >> + - reg
> >> + - interrupts
> >> + - "#mbox-cells"
> >> +
> >> +additionalProperties: false
> >> +
> >> +examples:
> >> + - |
> >> + #include <dt-bindings/interrupt-controller/irq.h>
> >> +
> >> + mbox@12c1c200 {
> >
> > mailbox@
> >
> > With these fixed:
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Huh, not tested.... so obviously un-reviewed.
>
> Test your code BEFORE you send, not via community services.
>
> Best regards,
> Krzysztof
Thanks for the review.
I will update accordingly and make sure test passed in later patch.
Best Regards,
Jammy Huang