Re: [PATCH v1 2/2] cxl/Documentation: Add more description about min/max scrub cycle

[Dave Jiang]

On 6/3/25 3:43 AM, Li Ming wrote:
> user can configurare scrub cycle for a region or a memory device via

s/configurare/configure/

> sysfs interface. Currently, these interfaces have not enough description
> for the return value. So adding return value description to these
> interfaces.
> 
> Suggested-by: Alison Schofield <alison.schofield@xxxxxxxxx>
> Signed-off-by: Shiju Jose <shiju.jose@xxxxxxxxxx>
> Signed-off-by: Li Ming <ming.li@xxxxxxxxxxxx>

Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>

> ---
>  Documentation/ABI/testing/sysfs-edac-scrub | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-edac-scrub b/Documentation/ABI/testing/sysfs-edac-scrub
> index c43be90deab4..ab6014743da5 100644
> --- a/Documentation/ABI/testing/sysfs-edac-scrub
> +++ b/Documentation/ABI/testing/sysfs-edac-scrub
> @@ -49,6 +49,12 @@ Description:
>  		(RO) Supported minimum scrub cycle duration in seconds
>  		by the memory scrubber.
>  
> +		Device-based scrub: returns the minimum scrub cycle
> +		supported by the memory device.
> +
> +		Region-based scrub: returns the max of minimum scrub cycles
> +		supported by individual memory devices that back the region.
> +
>  What:		/sys/bus/edac/devices/<dev-name>/scrubX/max_cycle_duration
>  Date:		March 2025
>  KernelVersion:	6.15
> @@ -57,6 +63,16 @@ Description:
>  		(RO) Supported maximum scrub cycle duration in seconds
>  		by the memory scrubber.
>  
> +		Device-based scrub: returns the maximum scrub cycle supported
> +		by the memory device.
> +
> +		Region-based scrub: returns the min of maximum scrub cycles
> +		supported by individual memory devices that back the region.
> +
> +		If the memory device does not provide maximum scrub cycle
> +		information, return the maximum supported value of the scrub
> +		cycle field.
> +
>  What:		/sys/bus/edac/devices/<dev-name>/scrubX/current_cycle_duration
>  Date:		March 2025
>  KernelVersion:	6.15