Re: [PATCH v6 4/9] x86/nmi: Assign and register NMI-source vectors

From: Sohil Mehta
Date: Tue Jun 03 2025 - 18:33:54 EST


On 6/3/2025 2:54 PM, Dave Hansen wrote:
> On 6/3/25 13:22, Sohil Mehta wrote:
>> With an enum, it's harder to figure out the exact sources when let's say
>> the source bitmap is printed as 0x0090.
>
> Uhh, then don't print a bitmap. ;)
>

Ah! Didn't look at it that way.

> /proc/cpuinfo doesn't print out CPUID leaves, it prints out bits mapped
> to strings.
>

Hasn't that caused more pains than gains :p But, point taken, I'll give
it a shot.

> Look at the kmalloc trace points:
>
> Xorg-4589 [003] ..... 1568557.823993: kmalloc: ...
> gfp_flags=GFP_KERNEL
> Xorg-4589 [003] ..... 1568557.823993: kmalloc: ...
> gfp_flags=GFP_KERNEL
>
> gfp_flags are a bitmap, yet they're mapped out with strings and symbolic
> names.