Re: [PATCH v2 01/10] sched: Add support to pick functions to take rf

[Tejun Heo]

On Tue, Jun 03, 2025 at 09:38:35AM -0400, Joel Fernandes wrote:
> On 6/2/2025 8:05 PM, Tejun Heo wrote:
> > Hello,
> > 
> > On Mon, Jun 02, 2025 at 02:00:57PM -0400, Joel Fernandes wrote:
> >> Some pick functions like the internal pick_next_task_fair() already take
> >> rf but some others dont. We need this for scx's server pick function.
> >> Prepare for this by having pick functions accept it.
> > 
> > Hmm.. after the whole patch series is applied, pick_task_scx() still doesn't
> > seem to use @rf. What am I missing?
> I need it for scx *server*'s pick_task, i.e. ext_server_pick_task().
> 
> Sure we're not using it in pick_task_scx(), but I added it there for consistency
> since pick_task_dl() needs it, due to ext_server_pick_task() needing it.

Ah, yeah, I just missed the usage on the server side. Thanks for the
explanation.

-- 
tejun