Re: [PATCH 1/2] dt-bindings: PCI: brcm,stb-pcie: Add num-lanes property

[Florian Fainelli]

On 6/3/25 10:16, Jim Quinlan wrote:
> On Tue, Jun 3, 2025 at 12:24 PM Florian Fainelli
> <florian.fainelli@xxxxxxxxxxxx> wrote:
> > On 5/30/25 16:32, Florian Fainelli wrote:
> > > On 5/30/25 15:40, Jim Quinlan wrote:
> > > > Add optional num-lanes property Broadcom STB PCIe host controllers.
> > > >
> > > > Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx>
> > >
> > > Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> >
> > Sorry I take that back, I think this should be:
> >
> > num-lanes:
> >     enum: [ 1, 2, 4 ]
> >
> > We are basically documenting the allowed values, not specifying that we
> > can repeat the num-lames property between 1 and 4 times.
>
> num-lanes is already defined as
>
>      enum: [ 1, 2, 4, 8, 16, 32 ]

Right, but then we need to re-define it with our own specific 
constraints, still, don't we?
--
Florian