Re: [PATCH] overflow: Introduce __DEFINE_FLEX for having no initializer

From: Alexander Lobakin
Date: Tue Jun 03 2025 - 09:55:54 EST


From: Kees Cook <kees@xxxxxxxxxx>
Date: Fri, 30 May 2025 12:13:16 -0700

> While not yet in the tree, there is a proposed patch[1] that was
> depending on the prior behavior of _DEFINE_FLEX, which did not have an
> explicit initializer. Provide this via __DEFINE_FLEX now, which can also
> have attributes applied (e.g. __uninitialized).
>
> Examples of the resulting initializer behaviors can be seen here:
> https://godbolt.org/z/P7Go8Tr33
>
> Link: https://lore.kernel.org/netdev/20250520205920.2134829-9-anthony.l.nguyen@xxxxxxxxx [1]
> Fixes: 47e36ed78406 ("overflow: Fix direct struct member initialization in _DEFINE_FLEX()")
> Signed-off-by: Kees Cook <kees@xxxxxxxxxx>

Looks great to me, thanks!

Also, double thanks for this hint about using __uninitialized to
mitigate perf hits with automatic stack initialization -- will
definitely help :)

Olek