Re: [PATCH v13 18/27] x86/resctrl: Add definitions for MBM event configuration

[Moger, Babu]

Hi Reinette,

On 5/29/2025 3:58 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 5/29/25 12:00 PM, Moger, Babu wrote:
> > On 5/22/25 23:41, Reinette Chatre wrote:
> > > On 5/15/25 3:52 PM, Babu Moger wrote:
>
>
> > > > +/**
> > > > + * struct mbm_evt_value - Specific type of memory events.
> > >
> > > I am trying to decipher the terminology. If these are events, then it becomes confusing
> > > since it becomes "these events are used to configure events". You mention "memory
> > > transaction" below, this sounds more accurate to me. Above could thus be:
> > >
> > > struct mbm_evt_value - Memory transaction an MBM event can be configured with.
> >
> > Sure.
> >
> > > The name of the struct could also do with a rename to avoid the "event" term that
> > > conflicts with the actual MBM events. Maybe "mbm_cfg_value" ... I do not think this
> > > is a good name so please consider what would work better.
> >
> > I can change it to "mbm_config_value".
>
> Looks good, thank you.
>
> ...
>
> > > > +#define NUM_MBM_EVT_VALUES             7
> > > > +
> > > > +/* Decoded values for each type of memory events */
> > >
> > > Please be consistent with terminology. In the above lines it switches
> > > between "memory transaction types" and "memory events".
> >
> > "Decoded values for each type of memory transaction types"
>
> I do not think "type" is needed twice. Could also be:
> "Decoded values of each memory transaction type."

Sure.

Thanks
Babu