Re: [PATCH v3 2/5] PM: sleep: Suspend async parents after suspending children

From: Rafael J. Wysocki
Date: Tue Jun 03 2025 - 07:38:30 EST


On Tue, Jun 3, 2025 at 12:30 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
>
> On Tue, Jun 3, 2025 at 12:29 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> >
> > On Tue, Jun 3, 2025 at 12:17 PM Chris Bainbridge
> > <chris.bainbridge@xxxxxxxxx> wrote:
> > >
> > > On Tue, Jun 03, 2025 at 11:38:37AM +0200, Rafael J. Wysocki wrote:
> > > >
> > > > Chris, please check if the attached patch helps. I'm going to post it
> > > > as a fix anyway later today, but it would be good to verify that it is
> > > > sufficient.
> > >
> > > This did not fix my test case, pstore crash log was:
> >
> > OK, so can you please enable PM debug messages:
> >
> > # echo 1 > /sys/power/pm_debug/messages
>
> This should be
>
> # echo 1 > /sys/power/pm_debug_messages
>
> sorry.
>
> > and enabled dynamic debug in drivers/base/power/main.c:
> >
> > # echo "file drivers/base/power/main.c +p" > /proc/dynamic_debug/control
> >
> > repeat the test and capture the log?

Actually, no need to do this, there is an obvious bug:
list_splice_init() should be used instead of list_splice() when the
emptied list is going to be used again. Ugh.

Please check if the attached patch along with the previous one makes
the issue go away entirely.