Re: [PATCH] clocksource/timer-econet-en751221: Convert comma to semicolon

[Caleb James DeLisle]

On 03/06/2025 08:04, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>

Tested-by: Caleb James DeLisle <cjd@xxxxxxxx>


The comma was indeed unintended, thank you.

Caleb

> ---
>   drivers/clocksource/timer-econet-en751221.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-econet-en751221.c b/drivers/clocksource/timer-econet-en751221.c
> index 3b449fdaafee..4008076b1a21 100644
> --- a/drivers/clocksource/timer-econet-en751221.c
> +++ b/drivers/clocksource/timer-econet-en751221.c
> @@ -146,7 +146,7 @@ static int __init cevt_init(struct device_node *np)
>   	for_each_possible_cpu(i) {
>   		struct clock_event_device *cd = &per_cpu(econet_timer_pcpu, i);
>   
> -		cd->rating		= 310,
> +		cd->rating		= 310;
>   		cd->features		= CLOCK_EVT_FEAT_ONESHOT |
>   					  CLOCK_EVT_FEAT_C3STOP |
>   					  CLOCK_EVT_FEAT_PERCPU;