Re: [PATCH] mm: Kconfig: Use verb *use* in plural form in description
From: Lorenzo Stoakes
Date: Tue Jun 03 2025 - 05:32:38 EST
On Tue, Jun 03, 2025 at 08:13:03AM +0200, Paul Menzel wrote:
> *workloads* is plural requiring the verb *use* in plural form.
>
> Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order")
I think a fixes is unnecessary here :) I mean strictly true, but we don't
need to backport a typo fix :P
> Signed-off-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
> ---
> Reading the sentence it feels like, something is missing before the
> *please*, but I am no native speaker.
Seems ok to me as a native speaker! Though I don't claim to be the most
erudite...
>
> mm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index f8bb8f070d0d..e3a07687ed0b 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -1022,7 +1022,7 @@ config PAGE_BLOCK_ORDER
> or MAX_PAGE_ORDER.
>
> Reducing pageblock order can negatively impact THP generation
> - success rate. If your workloads uses THP heavily, please use this
> + success rate. If your workloads use THP heavily, please use this
> option with caution.
>
> Don't change if unsure.
> --
> 2.49.0
>