Re: [PATCH v1 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series SoC

From: Krzysztof Kozlowski
Date: Tue Jun 03 2025 - 05:23:13 EST


On 03/06/2025 09:54, Jammy Huang wrote:
> +
> + interrupts:
> + maxItems: 1
> +
> + "#mbox-cells":
> + const: 1
> + description: |
> + <&phandle channel>
> + phandle : Label name of mailbox controller
> + channel : 0-3, Channel index

Drop description, pretty obvious (or just say that second argument is
channel number).

> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - "#mbox-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + mbox@12c1c200 {

mailbox@

With these fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>


Best regards,
Krzysztof