Re: [PATCH v10 01/11] dt-bindings: mfd: gpio: Add MAX7360
From: Mathieu Dubois-Briand
Date: Tue Jun 03 2025 - 04:14:55 EST
On Mon Jun 2, 2025 at 1:21 PM CEST, Krzysztof Kozlowski wrote:
> On 30/05/2025 12:00, Mathieu Dubois-Briand wrote:
>> Add device tree bindings for Maxim Integrated MAX7360 device with
>> support for keypad, rotary, gpios and pwm functionalities.
>>
>> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
>> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@xxxxxxxxxxx>
>> ---
>> .../bindings/gpio/maxim,max7360-gpio.yaml | 83 +++++++++
>> .../devicetree/bindings/mfd/maxim,max7360.yaml | 191 +++++++++++++++++++++
>> 2 files changed, 274 insertions(+)
>>
>
> <form letter>
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
> of patchset, under or above your Signed-off-by tag, unless patch changed
> significantly (e.g. new properties added to the DT bindings). Tag is
> "received", when provided in a message replied to you on the mailing
> list. Tools like b4 can help here. However, there's no need to repost
> patches *only* to add the tags. The upstream maintainer will do that for
> tags received on the version they apply.
>
> Please read:
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
>
I previously decided to drop your Reviewed-by tag as I made some
substantial changes since you gave it. Main difference since v4 of this
series is add of the pinctrl bindings and some additional
"rotary-encoder,*" properties.
>
> Best regards,
> Krzysztof
Best regards,
Mathieu
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com