Re: [PATCH] usb: dwc2: gadget: Use USB API functions rather than constants

[Minas Harutyunyan]

On 5/19/25 10:22, Chen Ni wrote:
> Use the function usb_endpoint_type() rather than constants.
> The Coccinelle semantic patch is as follows:
> 
> @@ struct usb_endpoint_descriptor *epd; @@
> 
> - (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
> + usb_endpoint_type(epd)
> 
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>

Acked-by: Minas Harutyunyan <hminas@xxxxxxxxxxxx>

> ---
>   drivers/usb/dwc2/gadget.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index f323fb5597b3..d5b622f78cf3 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -4049,7 +4049,7 @@ static int dwc2_hsotg_ep_enable(struct usb_ep *ep,
>   		return -EINVAL;
>   	}
>   
> -	ep_type = desc->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK;
> +	ep_type = usb_endpoint_type(desc);
>   	mps = usb_endpoint_maxp(desc);
>   	mc = usb_endpoint_maxp_mult(desc);
>